# Review package: 2f22df6..9362c47 ## Commits 9362c47 refactor: reuse shared header on G03 ## Files changed pages/genealogy/g03-create-genealogy.vue | 62 ++++---------------------------- tests/g03-create-flow-contract.ps1 | 9 +++-- tests/g03-document-flow-contract.ps1 | 4 ++- tests/g03-visual-states-contract.ps1 | 4 +-- 4 files changed, 17 insertions(+), 62 deletions(-) ## Diff diff --git a/pages/genealogy/g03-create-genealogy.vue b/pages/genealogy/g03-create-genealogy.vue index 2bc757d..f37cadc 100644 --- a/pages/genealogy/g03-create-genealogy.vue +++ b/pages/genealogy/g03-create-genealogy.vue @@ -1,30 +1,20 @@ ').Groups[1].Value $positions = [regex]::Matches([regex]::Replace($style, '(?s)/\*.*?\*/', ''), '(?m)\bposition\s*:\s*([^;]+);') if ($positions.Count -ne 1 -or $positions[0].Groups[1].Value.Trim() -ne 'fixed') { throw "G03 must retain only its combined fixed dialog layer rule; found $($positions.Count) position declarations" } foreach ($required in @( - 'background: url("/static/assets/foundation/opaque/root-header-cinnabar.jpg")', 'background: url("/static/assets/modules/genealogy/transparent/g01-empty-panel-frame.png")', 'background: url("/static/assets/modules/auth/transparent/a01-scroll-dialog-v3.png")', 'background: url("/static/assets/foundation/transparent/a01-scroll-primary-v3.png")' )) { if ($page -notmatch [regex]::Escape($required)) { throw "G03 is missing real asset background: $required" } } +foreach ($forbidden in @('flow-header', 'root-header-cinnabar.jpg')) { + if ($page -match [regex]::Escape($forbidden)) { throw "G03 must not retain private header token: $forbidden" } +} Write-Output 'G03-DOCUMENT-FLOW-CONTRACT PASS' diff --git a/tests/g03-visual-states-contract.ps1 b/tests/g03-visual-states-contract.ps1 index 5342acb..cfb7911 100644 --- a/tests/g03-visual-states-contract.ps1 +++ b/tests/g03-visual-states-contract.ps1 @@ -2,22 +2,22 @@ $ErrorActionPreference = 'Stop' $root = Split-Path -Parent $PSScriptRoot $g03 = Get-Content -LiteralPath (Join-Path $root 'pages/genealogy/g03-create-genealogy.vue') -Raw -Encoding utf8 function Assert-Match { param([string]$Content, [string]$Pattern, [string]$Message) if ($Content -notmatch $Pattern) { throw $Message } } if ($g03 -match '返回') { throw 'G03 header must use only the approved image back arrow' } -Assert-Match -Content $g03 -Pattern '(?s)\.flow-header__back,\s*\.flow-header__side\s*\{[^}]*width:\s*72rpx;' -Message 'G03 header side slots must preserve centered title after removing back text' -Assert-Match -Content $g03 -Pattern '(?s)\.flow-header__back-icon\s*\{[^}]*width:\s*34rpx;[^}]*height:\s*34rpx;' -Message 'G03 back arrow must use the approved visible size' +Assert-Match -Content $g03 -Pattern '(?s)' -Message 'G03 must use PageHeader with its dynamic title and custom back handler' +if ($g03 -match 'flow-header|flow-header__back|flow-header__title') { throw 'G03 must not retain a private header implementation' } Assert-Match -Content $g03 -Pattern '(?s)\.flow-note,\s*\.flow-rule__note\s*\{[^}]*font-size:\s*25rpx;' -Message 'G03 guidance copy must use the approved readable size' Assert-Match -Content $g03 -Pattern '(?s)\.flow-rule__option\s*\{[^}]*font-size:\s*23rpx;' -Message 'G03 visibility options must use the approved readable size' Assert-Match -Content $g03 -Pattern '(?s)\.field-error\s*\{[^}]*font-size:\s*24rpx;[^}]*line-height:\s*34rpx;' -Message 'G03 field errors must use the approved readable size' Assert-Match -Content $g03 -Pattern '(?s)\.flow-error\s*\{[^}]*font-size:\s*25rpx;[^}]*line-height:\s*36rpx;' -Message 'G03 submit errors must use the approved readable size' foreach ($asset in @('a01-scroll-dialog-v3.png', 'a01-scroll-primary-v3.png', 'a01-scroll-secondary-v3.png')) { if ($g03 -notmatch [regex]::Escape($asset)) { throw "G03 must retain approved shared asset: $asset" } } Write-Output 'G03-VISUAL-STATES-CONTRACT PASS'